| File TODO changed (mode: 100644) (index c1e5406..aea65d9) |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 15 |
15 |
|
|
| 16 |
16 |
|
|
| 17 |
17 |
== BEFORE NEXT RELEASE == |
== BEFORE NEXT RELEASE == |
|
18 |
|
[ ] Allow repo admins to delete notes/bugs/etc. |
| 18 |
19 |
[ ] Seems that some other unit test is messing with repo.php ids. |
[ ] Seems that some other unit test is messing with repo.php ids. |
| 19 |
20 |
Change ids to be protected from interference. |
Change ids to be protected from interference. |
| 20 |
21 |
[ ] Use bintray.com to distribute isos? |
[ ] Use bintray.com to distribute isos? |
| 21 |
22 |
[ ] When creating an account, seems the email is cached, not the username! |
[ ] When creating an account, seems the email is cached, not the username! |
| 22 |
23 |
Check! |
Check! |
|
24 |
|
[ ] Users should be able to check the plans. |
| 23 |
25 |
[ ] After login, show the last ip and date of the last login? |
[ ] After login, show the last ip and date of the last login? |
| 24 |
26 |
[ ] I should show some 'plan' islands when you create the account |
[ ] I should show some 'plan' islands when you create the account |
| 25 |
27 |
so the user will know the disk space and bandwidth. |
so the user will know the disk space and bandwidth. |
| 26 |
28 |
[ ] In a table, if nothing can be deleted, do not show the delete button. |
[ ] In a table, if nothing can be deleted, do not show the delete button. |
| 27 |
|
[ ] Add IP address in /etc/issue (or /etc/motd), somehw to appear, maybe using |
|
|
29 |
|
[ ] Add IP address in /etc/issue (or /etc/motd), somehow to appear, maybe using |
| 28 |
30 |
a systemd script that runs before terminal? |
a systemd script that runs before terminal? |
| 29 |
31 |
[ ] web hooks: start with a http post to a custom server. |
[ ] web hooks: start with a http post to a custom server. |
| 30 |
32 |
[ ] When giving some users rights to your repo, do not spam them with |
[ ] When giving some users rights to your repo, do not spam them with |
| 31 |
33 |
messages. The user must agree to be spammed. Best, no notification |
messages. The user must agree to be spammed. Best, no notification |
| 32 |
34 |
is ever issued. User may go to project to activate them if s/he wants. |
is ever issued. User may go to project to activate them if s/he wants. |
|
35 |
|
Better, show some notifications in the top bar? |
| 33 |
36 |
(see Linus Torvalds post about GitHub) |
(see Linus Torvalds post about GitHub) |
| 34 |
37 |
[ ] Add a cache based on content. For example, if a repo was last changed |
[ ] Add a cache based on content. For example, if a repo was last changed |
| 35 |
38 |
at timestamp t1, add a cache entry 'history''t1' with the content |
at timestamp t1, add a cache entry 'history''t1' with the content |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 52 |
55 |
[ ] Run the tests also with cache down (on the server side). |
[ ] Run the tests also with cache down (on the server side). |
| 53 |
56 |
[ ] Show who is watching a bug. |
[ ] Show who is watching a bug. |
| 54 |
57 |
[ ] Mess with session_*() functions to achieve some vars persistence. |
[ ] Mess with session_*() functions to achieve some vars persistence. |
| 55 |
|
[ ] Add a para to rg_token_get to specify the form (ex: 'login'), this way |
|
| 56 |
|
we can still cache the other pages, becasue that token is not |
|
| 57 |
|
marked as used. |
|
| 58 |
58 |
[ ] Add some area with citations? |
[ ] Add some area with citations? |
| 59 |
59 |
- I find people who think open-source is anti-capitalism to be kind |
- I find people who think open-source is anti-capitalism to be kind |
| 60 |
60 |
of naive and slightly stupid. (bloomberg.com) |
of naive and slightly stupid. (bloomberg.com) |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 68 |
68 |
[ ] Why 'not github' articles, should be integrated somewhere: |
[ ] Why 'not github' articles, should be integrated somewhere: |
| 69 |
69 |
http://www.valdyas.org/fading/index.cgi/2015/05/29#no-github |
http://www.valdyas.org/fading/index.cgi/2015/05/29#no-github |
| 70 |
70 |
http://www.adamhyde.net/why-github-is-bad-for-open-source/ |
http://www.adamhyde.net/why-github-is-bad-for-open-source/ |
| 71 |
|
[ ] Add sha1sum of the images |
|
|
71 |
|
[ ] Add sha1sum of the VM images |
| 72 |
72 |
[ ] Show user the entry that must be added for known_hosts |
[ ] Show user the entry that must be added for known_hosts |
| 73 |
73 |
[ ] LDAP: http://mageconfig.blogspot.ro/2014/06/configure-gitgerrit-with-open-ldap-for.html |
[ ] LDAP: http://mageconfig.blogspot.ro/2014/06/configure-gitgerrit-with-open-ldap-for.html |
| 74 |
74 |
[ ] Leave alone the ssh key comment! More exactly, do not convert unk chars. |
[ ] Leave alone the ssh key comment! More exactly, do not convert unk chars. |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 80 |
80 |
"You have no key uploaded, go to ..." |
"You have no key uploaded, go to ..." |
| 81 |
81 |
[ ] For 'log' and 'tree' we have decorations for links! |
[ ] For 'log' and 'tree' we have decorations for links! |
| 82 |
82 |
[ ] In "Tree" section, seems the path is doubled. |
[ ] In "Tree" section, seems the path is doubled. |
| 83 |
|
[ ] Hint: where in fs you can find the repo. |
|
|
83 |
|
[ ] Hint: where in fs you can find the repo. Only for admins? |
| 84 |
84 |
[ ] Hints should not call rg_template, let next rg_template_table to do it. |
[ ] Hints should not call rg_template, let next rg_template_table to do it. |
| 85 |
85 |
(to avoid double replace). |
(to avoid double replace). |
| 86 |
86 |
Anyway, we already do double replace for hints) |
Anyway, we already do double replace for hints) |
| 87 |
|
[ ] Generate the VM SSL cert at boot time to avoid that famous Firefox bug. |
|
| 88 |
87 |
[ ] Saving fields in forms when session exired to be reused next time. |
[ ] Saving fields in forms when session exired to be reused next time. |
| 89 |
88 |
[ ] Compression off for ssh because objects are already compressed? |
[ ] Compression off for ssh because objects are already compressed? |
| 90 |
89 |
[ ] Add a random token in header to prevent watermarking (this is the name?). |
[ ] Add a random token in header to prevent watermarking (this is the name?). |
| 91 |
90 |
[ ] User home page link is missing from top bar! use login_ui::homepage. |
[ ] User home page link is missing from top bar! use login_ui::homepage. |
| 92 |
91 |
[ ] Add "Spread the word!" on website. |
[ ] Add "Spread the word!" on website. |
| 93 |
92 |
[ ] Give up on submenu1/2 and integrate them when needed? |
[ ] Give up on submenu1/2 and integrate them when needed? |
| 94 |
|
[ ] I have a common part in download-vm.html, deal with it. |
|
| 95 |
93 |
[ ] https://www.kernel.org/pub/software/scm/git/docs/gitworkflows.html |
[ ] https://www.kernel.org/pub/software/scm/git/docs/gitworkflows.html |
| 96 |
94 |
[ ] git-name-rev is nice. |
[ ] git-name-rev is nice. |
| 97 |
95 |
[ ] git pack-redundant should be called after git gc? And then prune-packed? |
[ ] git pack-redundant should be called after git gc? And then prune-packed? |
| 98 |
96 |
[ ] git-relink for really cloned repos? |
[ ] git-relink for really cloned repos? |
| 99 |
97 |
[ ] Allow creating tags/branches on web interface. |
[ ] Allow creating tags/branches on web interface. |
| 100 |
|
[ ] For mails, we should not escape vars! |
|
| 101 |
|
[ ] Users should be able to check the plans. |
|
| 102 |
98 |
[ ] Use a separate template for main rocketgit.com site. The other users |
[ ] Use a separate template for main rocketgit.com site. The other users |
| 103 |
99 |
should not see the same pages. |
should not see the same pages. |
| 104 |
100 |
[ ] git-filter-branch is very powerful: offer it to the clients! |
[ ] git-filter-branch is very powerful: offer it to the clients! |
| 105 |
101 |
[ ] word-break: break-all; pentru tabelele cu cod. asta permite wrap-ul |
[ ] word-break: break-all; pentru tabelele cu cod. asta permite wrap-ul |
| 106 |
102 |
oriunde - still needed?! |
oriunde - still needed?! |
| 107 |
103 |
[ ] On upgrade, we must restart the cache daemon? |
[ ] On upgrade, we must restart the cache daemon? |
| 108 |
|
[ ] Real SSL certificates. |
|
| 109 |
104 |
[ ] Backup for rg2! |
[ ] Backup for rg2! |
| 110 |
105 |
[ ] Sign vm images. |
[ ] Sign vm images. |
| 111 |
|
[ ] Run tidy on http_* tests to validate the HTML. |
|
| 112 |
|
[ ] Check if link to repos are created in /var/lib/rocketgit/by_name. |
|
| 113 |
|
I suspect they are not always created. |
|
| 114 |
106 |
[ ] Add uid to events so we can delete old events for tests or abusing users? |
[ ] Add uid to events so we can delete old events for tests or abusing users? |
| 115 |
107 |
[ ] Should we just set no password somehow for ssh access to be able to signal |
[ ] Should we just set no password somehow for ssh access to be able to signal |
| 116 |
108 |
the user that has no key uploaded? |
the user that has no key uploaded? |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 120 |
112 |
[ ] merge.html hint is not used. |
[ ] merge.html hint is not used. |
| 121 |
113 |
[ ] On create repo form if somebody puts a space, the message does not tell |
[ ] On create repo form if somebody puts a space, the message does not tell |
| 122 |
114 |
what chars are invalid/permited (reported by Ionut). |
what chars are invalid/permited (reported by Ionut). |
| 123 |
|
[ ] Avoid alst two err- files at install time. Check if table state exists? |
|
| 124 |
|
And cache this info? |
|
| 125 |
115 |
[ ] Security: Link-uri + xss (Ionut) |
[ ] Security: Link-uri + xss (Ionut) |
| 126 |
116 |
[ ] I am able to disable merge/pull requests? Anon yes, but the other ones? |
[ ] I am able to disable merge/pull requests? Anon yes, but the other ones? |
| 127 |
117 |
[ ] report1: add disk space |
[ ] report1: add disk space |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 146 |
136 |
the db? |
the db? |
| 147 |
137 |
[ ] When a user succesfuly log in, generate a signed token to be used in case |
[ ] When a user succesfuly log in, generate a signed token to be used in case |
| 148 |
138 |
of brute force attack on his account. With that token he will be able |
of brute force attack on his account. With that token he will be able |
| 149 |
|
to bypass rate limitting. |
|
|
139 |
|
to bypass rate limitting. By cookie? |
| 150 |
140 |
[ ] slogan: it is not rocket science |
[ ] slogan: it is not rocket science |
| 151 |
141 |
[ ] Only one daemon should update the structure, else they will conflict. |
[ ] Only one daemon should update the structure, else they will conflict. |
| 152 |
|
Dpne. Check. |
|
|
142 |
|
Done. Check. |
| 153 |
143 |
[ ] nofollow la logout; poate si in alte parti |
[ ] nofollow la logout; poate si in alte parti |
| 154 |
144 |
[ ] Check if SSL cyphers are ok |
[ ] Check if SSL cyphers are ok |
| 155 |
145 |
[ ] Se pare ca autogenerez drepturi 'All' pentru orice user asupra repo-ului. |
[ ] Se pare ca autogenerez drepturi 'All' pentru orice user asupra repo-ului. |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 167 |
157 |
gen: http://rocketgit.com/op/features, daca vrei poti incerca sa |
gen: http://rocketgit.com/op/features, daca vrei poti incerca sa |
| 168 |
158 |
folosesti css3, flex-box, ceva informatii gasesti aici: |
folosesti css3, flex-box, ceva informatii gasesti aici: |
| 169 |
159 |
http://www.w3schools.com/cssref/css3_pr_flex-flow.asp |
http://www.w3schools.com/cssref/css3_pr_flex-flow.asp |
| 170 |
|
[ ] Would be nice to give more informations when we auto generate keys |
|
| 171 |
|
- something like 'Autogenerated - because repo is public". |
|
| 172 |
|
[ ] Deal with keys with spaces. |
|
| 173 |
160 |
[ ] Add an invite form (only for logged-in people - because of spam) that |
[ ] Add an invite form (only for logged-in people - because of spam) that |
| 174 |
161 |
will send mail to a friend with all the details. |
will send mail to a friend with all the details. |
| 175 |
162 |
[ ] Graph with the server load. |
[ ] Graph with the server load. |
| |
| ... |
... |
to store it in db. Why not? Because of caching of the pages... |
| 181 |
168 |
it with rg_template*). |
it with rg_template*). |
| 182 |
169 |
[ ] If there are a lot of tags/branches, remove oldest ones. |
[ ] If there are a lot of tags/branches, remove oldest ones. |
| 183 |
170 |
[ ] Add a "Stats" menu per repo: at least disk size. |
[ ] Add a "Stats" menu per repo: at least disk size. |
| 184 |
|
[ ] Seems we are stuck processing events in events.php daemon because we are |
|
| 185 |
|
stuck in 'accept'. We should keep processing the events queue. |
|
| 186 |
|
I think this was because we did not signal the daemon. Can be closed? |
|
| 187 |
171 |
[ ] Accessing a file with '"' inside, is not working. |
[ ] Accessing a file with '"' inside, is not working. |
| 188 |
172 |
See rocketgit.com/user/catalinux/test1/source/tree/blob/"xx\"yy" |
See rocketgit.com/user/catalinux/test1/source/tree/blob/"xx\"yy" |
| 189 |
|
[ ] Build a vm image to offer for download. |
|
| 190 |
|
[ ] Add an option to specify a license for the projects. |
|
| 191 |
173 |
[ ] Present bugs as a git repo, so we easily add a new one by push? |
[ ] Present bugs as a git repo, so we easily add a new one by push? |
| 192 |
174 |
[ ] Configuration: a number of months to keep history (see slaves). |
[ ] Configuration: a number of months to keep history (see slaves). |
| 193 |
175 |
[ ] vagrant install? |
[ ] vagrant install? |
| |
| ... |
... |
mails to be saved in a folder, so we can parse them and verify them. |
| 216 |
198 |
Only add the regen event! Why? At start we have no users and the first |
Only add the regen event! Why? At start we have no users and the first |
| 217 |
199 |
key added will generate a trigger. |
key added will generate a trigger. |
| 218 |
200 |
May be other places where I run as root! |
May be other places where I run as root! |
| 219 |
|
[ ] init.php: do not show the password! |
|
| 220 |
|
Maybe switch to a web based instalation? |
|
| 221 |
201 |
[ ] I must mark that init.php script was not run, and do not start daemons! |
[ ] I must mark that init.php script was not run, and do not start daemons! |
| 222 |
202 |
Else, timezone nasty messages will appear in the logs and only a |
Else, timezone nasty messages will appear in the logs and only a |
| 223 |
203 |
restart will fix the problem. |
restart will fix the problem. |
| |
| ... |
... |
mails to be saved in a folder, so we can parse them and verify them. |
| 236 |
216 |
[ ] Should we skip SELECT/INSERT steps for logout (in token_valid)? |
[ ] Should we skip SELECT/INSERT steps for logout (in token_valid)? |
| 237 |
217 |
[ ] Persistent connection to database? |
[ ] Persistent connection to database? |
| 238 |
218 |
[ ] Check cache socket is protected against other users. |
[ ] Check cache socket is protected against other users. |
| 239 |
|
[ ] token: add form id into equation? |
|
| 240 |
219 |
[ ] Ce se intimpla daca un atacator seteaza un cookie pe .com, de exemplu. |
[ ] Ce se intimpla daca un atacator seteaza un cookie pe .com, de exemplu. |
| 241 |
220 |
El se va trimite si pe rocketgit.com. Deci, daca user-ul viziteaza site-ul |
El se va trimite si pe rocketgit.com. Deci, daca user-ul viziteaza site-ul |
| 242 |
221 |
atacatorului, se seteaza acest cookie, care apoi va fi trimis catre rg.com. |
atacatorului, se seteaza acest cookie, care apoi va fi trimis catre rg.com. |
| |
| ... |
... |
Daca as lega good.com de a/b, as putea elimina cookie-urile rele. |
| 272 |
251 |
[ ] Should we delete previous session when user calls login if the user is |
[ ] Should we delete previous session when user calls login if the user is |
| 273 |
252 |
already logged-in? |
already logged-in? |
| 274 |
253 |
[ ] Talk in installation about a php compiler? |
[ ] Talk in installation about a php compiler? |
| 275 |
|
[ ] cache_set should wait for an answer? Should we send an answer? |
|
| 276 |
254 |
[ ] security_violation_no_exit -> security_violation? To not spend resources? |
[ ] security_violation_no_exit -> security_violation? To not spend resources? |
| 277 |
255 |
[ ] We should be able to have multiple logins (think desktop and phone). |
[ ] We should be able to have multiple logins (think desktop and phone). |
| 278 |
256 |
[ ] Test if cache is faster than postgres. If not, get rid of cache! |
[ ] Test if cache is faster than postgres. If not, get rid of cache! |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 341 |
319 |
[ ] We have big races for cache. But, the same with the database. |
[ ] We have big races for cache. But, the same with the database. |
| 342 |
320 |
[ ] Retest repo rename. Better, add an unit test. |
[ ] Retest repo rename. Better, add an unit test. |
| 343 |
321 |
[ ] When changing rights, invalidate/update cache. |
[ ] When changing rights, invalidate/update cache. |
| 344 |
|
[ ] Replace rg_var_str with rg_var_str_core. It is ok to not have escaped in |
|
| 345 |
|
db, but be careful with "HTML:" construct! Audit all HTML: and then |
|
| 346 |
|
switch. Do not forget that is a problem how it works now: |
|
| 347 |
|
for example, description that contains '<' will not work correctly. |
|
| 348 |
|
The problem is with HTML: vars that include un-escaped vars. |
|
| 349 |
|
Is it possible? |
|
| 350 |
|
Seems is working for repo description. Do it everywhere? |
|
| 351 |
322 |
[ ] Add unit test for inject functions. |
[ ] Add unit test for inject functions. |
| 352 |
323 |
[ ] Description passed in e-mail, may have security implications? |
[ ] Description passed in e-mail, may have security implications? |
| 353 |
324 |
[ ] keywords for search. Really needed? |
[ ] keywords for search. Really needed? |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 368 |
339 |
[ ] In cache, what if a var has \n in it? |
[ ] In cache, what if a var has \n in it? |
| 369 |
340 |
[ ] Purge deleted bugs (and notes) in background |
[ ] Purge deleted bugs (and notes) in background |
| 370 |
341 |
[ ] Event for bug delete. |
[ ] Event for bug delete. |
| 371 |
|
[ ] CIneva sterge un bug, si apoi altcineva apasa "delete" pe acelasi bug. |
|
|
342 |
|
[ ] Cineva sterge un bug, si apoi altcineva apasa "delete" pe acelasi bug. |
| 372 |
343 |
Va da eroare, dar nu ar trebui sa fie fatala... Eventual sa afisam |
Va da eroare, dar nu ar trebui sa fie fatala... Eventual sa afisam |
| 373 |
344 |
si cine a sters acel bug. |
si cine a sters acel bug. |
| 374 |
345 |
[ ] No expiration for cache?! |
[ ] No expiration for cache?! |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 387 |
358 |
[ ] repos.disk_quota_mb must be dropped and do a look-up in plan. |
[ ] repos.disk_quota_mb must be dropped and do a look-up in plan. |
| 388 |
359 |
[ ] Integrate max_public/private_repos into HL. |
[ ] Integrate max_public/private_repos into HL. |
| 389 |
360 |
[ ] Allow specifying base language for a project. |
[ ] Allow specifying base language for a project. |
| 390 |
|
[ ] Allow specifying license for a project. |
|
| 391 |
361 |
[ ] When changing db structure, invalidate all caches. |
[ ] When changing db structure, invalidate all caches. |
| 392 |
362 |
[ ] When we will switch to C, check UTF-8 validation. |
[ ] When we will switch to C, check UTF-8 validation. |
| 393 |
363 |
[ ] Check http://blog.wikichoon.com/2014/04/github-doesnt-support-pull-request.html |
[ ] Check http://blog.wikichoon.com/2014/04/github-doesnt-support-pull-request.html |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 508 |
478 |
for a user deletion. |
for a user deletion. |
| 509 |
479 |
[ ] rights.misc2 is not used now. Drop it. |
[ ] rights.misc2 is not used now. Drop it. |
| 510 |
480 |
[ ] How do we set rg_git_host? Now it shows r1i! |
[ ] How do we set rg_git_host? Now it shows r1i! |
| 511 |
|
[ ] bugs: when I edit a bug, if I wrongly insert a field, description is |
|
| 512 |
|
htmlized again (< -> <)! Probably in many other places. |
|
| 513 |
|
[ ] bugs: we must be able to delete bugs. |
|
| 514 |
481 |
[ ] Do not test if we watch a bug if the bug is new. |
[ ] Do not test if we watch a bug if the bug is new. |
| 515 |
482 |
[ ] repo-home->"Lock repo" + hint=(options to block fetches/commits/bug/etc.) |
[ ] repo-home->"Lock repo" + hint=(options to block fetches/commits/bug/etc.) |
| 516 |
483 |
and with reason that is logged in history and shown on access. |
and with reason that is logged in history and shown on access. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 519 |
486 |
repo. It may not be the same person that created it! |
repo. It may not be the same person that created it! |
| 520 |
487 |
[ ] Add a description field for rights and keys. Maybe other places. |
[ ] Add a description field for rights and keys. Maybe other places. |
| 521 |
488 |
[ ] Check http://nvie.com/posts/a-successful-git-branching-model/ |
[ ] Check http://nvie.com/posts/a-successful-git-branching-model/ |
| 522 |
|
[ ] After resetting password, go to the login form, with user pre-filed so the user can cache the password. |
|
|
489 |
|
[ ] After resetting password, go to the login form, with user pre-filed so |
|
490 |
|
the user can cache the password. |
| 523 |
491 |
[ ] Add number of bugs multiplied with a value to total disk space. |
[ ] Add number of bugs multiplied with a value to total disk space. |
| 524 |
492 |
[ ] How should I verify repo rights? |
[ ] How should I verify repo rights? |
| 525 |
493 |
if (admin) |
if (admin) |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 606 |
574 |
to login. Maybe just increase the delay for login? Maybe notify user |
to login. Maybe just increase the delay for login? Maybe notify user |
| 607 |
575 |
how many attempts were before successful login. |
how many attempts were before successful login. |
| 608 |
576 |
[ ] remote.php: call keys_update_use from an event. |
[ ] remote.php: call keys_update_use from an event. |
| 609 |
|
[ ] Allow user to change timezone! |
|
| 610 |
577 |
[ ] Prea mult spatiu gol la notificarea de schimbare repo. |
[ ] Prea mult spatiu gol la notificarea de schimbare repo. |
| 611 |
578 |
[ ] @@if: if after {{/}} follows a \n, just remove it? Maybe only if the if |
[ ] @@if: if after {{/}} follows a \n, just remove it? Maybe only if the if |
| 612 |
579 |
tokens are the only things on a line. |
tokens are the only things on a line. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 615 |
582 |
This is fixed with rg_user_allow_access. It should be used everywhere. |
This is fixed with rg_user_allow_access. It should be used everywhere. |
| 616 |
583 |
[ ] Maybe do not deny account creation, but put them on a special state |
[ ] Maybe do not deny account creation, but put them on a special state |
| 617 |
584 |
and ask admin to allow it? |
and ask admin to allow it? |
| 618 |
|
[ ] $sid to be masked behind a function (rg_user_get_sid). |
|
| 619 |
|
[ ] Use curl to auto test all web functionality fast. |
|
| 620 |
585 |
[ ] info.php shouldn't be converted to high-level function?! |
[ ] info.php shouldn't be converted to high-level function?! |
| 621 |
586 |
[ ] Move sending e-mails to event. |
[ ] Move sending e-mails to event. |
| 622 |
587 |
[ ] Think about renaming repositories to projects. Because they contain also |
[ ] Think about renaming repositories to projects. Because they contain also |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 624 |
589 |
some modules (git/bug tracker/etc.). |
some modules (git/bug tracker/etc.). |
| 625 |
590 |
[ ] When a push/etc. takes places, add an event to recompute disk size! |
[ ] When a push/etc. takes places, add an event to recompute disk size! |
| 626 |
591 |
Then, remove this from cron. |
Then, remove this from cron. |
| 627 |
|
[ ] If user applies for open-source type account, do not allow private repos. |
|
| 628 |
592 |
[ ] Move rg_account_allow_creation and other configuration stuff into admin area. |
[ ] Move rg_account_allow_creation and other configuration stuff into admin area. |
| 629 |
593 |
[ ] How to set default rights for new users? Maybe a section in admin area? |
[ ] How to set default rights for new users? Maybe a section in admin area? |
| 630 |
594 |
[ ] Computing disk size must invalidate the user cache. Or update it? |
[ ] Computing disk size must invalidate the user cache. Or update it? |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 636 |
600 |
At least: xinetd, cron etc. Probably not, but I must test this. |
At least: xinetd, cron etc. Probably not, but I must test this. |
| 637 |
601 |
[ ] Think about generating more tokens. Maybe just sign them to not be forced |
[ ] Think about generating more tokens. Maybe just sign them to not be forced |
| 638 |
602 |
to save them in database. At least generate more than one and cache them. |
to save them in database. At least generate more than one and cache them. |
| 639 |
|
[ ] There is a small possibility for files that are called from cron to not |
|
| 640 |
|
have correct context (cron instead rocketgit_t). Seems I fixed it |
|
| 641 |
|
with check_context function. |
|
| 642 |
603 |
[ ] Allow upload a ssh key as a file, not only paste it in textarea. |
[ ] Allow upload a ssh key as a file, not only paste it in textarea. |
| 643 |
604 |
[ ] Merge $more in all places where we add events. |
[ ] Merge $more in all places where we add events. |
| 644 |
605 |
[ ] Invite a friend. |
[ ] Invite a friend. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 668 |
629 |
ssh rocketgit@host create-account --ssh-key `cat key.pub` <name>. |
ssh rocketgit@host create-account --ssh-key `cat key.pub` <name>. |
| 669 |
630 |
ssh rocketgit@host disable-account <name>. |
ssh rocketgit@host disable-account <name>. |
| 670 |
631 |
Of course, check rights. |
Of course, check rights. |
| 671 |
|
[ ] Add unit testing for high level functions. |
|
| 672 |
632 |
[ ] Add unit testing for plans and rg_user_over_limit. |
[ ] Add unit testing for plans and rg_user_over_limit. |
| 673 |
633 |
[ ] Switch to *_high_level functions. |
[ ] Switch to *_high_level functions. |
| 674 |
634 |
[ ] When user press submit in a form and session expired, save in a cookie all |
[ ] When user press submit in a form and session expired, save in a cookie all |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 684 |
644 |
Also session may be updated from this event, but still with a 1 min gap. |
Also session may be updated from this event, but still with a 1 min gap. |
| 685 |
645 |
[ ] A script to check if all CSS classes in templates are present in css file. |
[ ] A script to check if all CSS classes in templates are present in css file. |
| 686 |
646 |
[ ] Export/import a repo (xml maybe). |
[ ] Export/import a repo (xml maybe). |
| 687 |
|
[ ] Add groups. |
|
| 688 |
647 |
[ ] We should warn the user if some users have lower rights than the default! |
[ ] We should warn the user if some users have lower rights than the default! |
| 689 |
648 |
[ ] Auto-create repos at clone phase, not only at push phase. |
[ ] Auto-create repos at clone phase, not only at push phase. |
| 690 |
649 |
[ ] The link to a note should have an anchor to be able to go directly to the note. |
[ ] The link to a note should have an anchor to be able to go directly to the note. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 704 |
663 |
[ ] Careful order the events. We do not want to build list notifications |
[ ] Careful order the events. We do not want to build list notifications |
| 705 |
664 |
before adding a user to the watch list. |
before adding a user to the watch list. |
| 706 |
665 |
[ ] If description is empty, do not insert a \n in 'new repo' e-mail. |
[ ] If description is empty, do not insert a \n in 'new repo' e-mail. |
| 707 |
|
[ ] Current menu is not correctly shown as selected. |
|
| 708 |
666 |
[ ] If the confirmation code is truncated, an internal error is generated |
[ ] If the confirmation code is truncated, an internal error is generated |
| 709 |
667 |
instead of a user error! |
instead of a user error! |
| 710 |
668 |
[ ] Third option: anybody can create an account but must be validated by admin. |
[ ] Third option: anybody can create an account but must be validated by admin. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 719 |
677 |
[ ] When I edit a bug, should I remove notes and add_note form? |
[ ] When I edit a bug, should I remove notes and add_note form? |
| 720 |
678 |
[ ] Add possibility to add/remove labels when adding a note? |
[ ] Add possibility to add/remove labels when adding a note? |
| 721 |
679 |
[ ] Bugs: show what filtering is active. |
[ ] Bugs: show what filtering is active. |
| 722 |
|
[ ] Seems I cannot push to rg1! Do an update and check again? |
|
| 723 |
680 |
[ ] Bug: Do not allow adding labels if you do not have admin rights. |
[ ] Bug: Do not allow adding labels if you do not have admin rights. |
| 724 |
681 |
[ ] Bug: Do not allow close/assign/etc. if you do not have admin rights. |
[ ] Bug: Do not allow close/assign/etc. if you do not have admin rights. |
| 725 |
682 |
[ ] Menu must be loaded from template. |
[ ] Menu must be loaded from template. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 745 |
702 |
ignore request before that timestamp. |
ignore request before that timestamp. |
| 746 |
703 |
[ ] We should make stuff more robust. For example: CREATE REPO + HISTORY_INSERT. |
[ ] We should make stuff more robust. For example: CREATE REPO + HISTORY_INSERT. |
| 747 |
704 |
[ ] We have to record the renaming in the repo history. |
[ ] We have to record the renaming in the repo history. |
| 748 |
|
[ ] What happens if a user is doing a downgrade? Must not allow it. |
|
| 749 |
705 |
[ ] Use another home page for logged in users. |
[ ] Use another home page for logged in users. |
| 750 |
706 |
[ ] repo_invalidate_cache does an implode that can reorder. Use repo_id as key? |
[ ] repo_invalidate_cache does an implode that can reorder. Use repo_id as key? |
| 751 |
707 |
No. But use some combinations of paras. |
No. But use some combinations of paras. |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 754 |
710 |
[ ] Check if there are unused parameters after name2base(_path). |
[ ] Check if there are unused parameters after name2base(_path). |
| 755 |
711 |
[ ] Remove any trace of $rr. |
[ ] Remove any trace of $rr. |
| 756 |
712 |
[ ] How to deal with browser accessing an old name (after rename)? |
[ ] How to deal with browser accessing an old name (after rename)? |
| 757 |
|
[ ] repo.php tests does not say "ok". |
|
| 758 |
713 |
[ ] Functions from util.inc.php set rg_util_error(). Use it. |
[ ] Functions from util.inc.php set rg_util_error(). Use it. |
| 759 |
714 |
[ ] Remove all "exit(?)" calls. |
[ ] Remove all "exit(?)" calls. |
| 760 |
715 |
[ ] Locking is done in global dirs for tests. Use a local folder! |
[ ] Locking is done in global dirs for tests. Use a local folder! |
| |
| ... |
... |
But, we have a problem with the expiration time! |
| 775 |
730 |
them after processing is done. |
them after processing is done. |
| 776 |
731 |
[ ] Description should not be present anywhere (web). Takes space. |
[ ] Description should not be present anywhere (web). Takes space. |
| 777 |
732 |
[ ] Seems that ls \.\. works. Check from security pov. |
[ ] Seems that ls \.\. works. Check from security pov. |
| 778 |
|
[ ] Profiling in not re-entrant. We should use a stack! |
|
|
733 |
|
[ ] Profiling is not re-entrant. We should use a stack! |
| 779 |
734 |
[ ] We should not store repo_id0 into cache! |
[ ] We should not store repo_id0 into cache! |
| 780 |
735 |
[ ] We are redirecting the user to history page. Do not wait for git dir! |
[ ] We are redirecting the user to history page. Do not wait for git dir! |
| 781 |
736 |
[ ] Set a policy in config.php and do the cleaning/compress of the log files. |
[ ] Set a policy in config.php and do the cleaning/compress of the log files. |
| |
| ... |
... |
them after processing is done. |
| 794 |
749 |
[ ] Specify a timeout for push/fetch. |
[ ] Specify a timeout for push/fetch. |
| 795 |
750 |
[ ] Describe also the installation. |
[ ] Describe also the installation. |
| 796 |
751 |
[ ] Allow search from the first page. |
[ ] Allow search from the first page. |
| 797 |
|
[ ] Send notifications when a user is given rights to a repo. |
|
| 798 |
752 |
[ ] Detect hexa strings and link them to commits. |
[ ] Detect hexa strings and link them to commits. |
| 799 |
753 |
[ ] Any user on a machine can look at repositories. |
[ ] Any user on a machine can look at repositories. |
| 800 |
754 |
Any user can connect to database. Fix also the README after fixing this. |
Any user can connect to database. Fix also the README after fixing this. |
| |
| ... |
... |
them after processing is done. |
| 822 |
776 |
other branch? |
other branch? |
| 823 |
777 |
[ ] See diff for merge requests. |
[ ] See diff for merge requests. |
| 824 |
778 |
[ ] On master, list clones. |
[ ] On master, list clones. |
| 825 |
|
[ ] Configuration: switch for SSL only. |
|
| 826 |
779 |
[ ] Internal mailing list? Or internal mail? |
[ ] Internal mailing list? Or internal mail? |
| 827 |
780 |
[ ] We should have a cron/q/remote for every config file! |
[ ] We should have a cron/q/remote for every config file! |
| 828 |
781 |
Or, at least, to be host aware. |
Or, at least, to be host aware. |
| 829 |
782 |
[ ] Install text files in /usr/share/doc |
[ ] Install text files in /usr/share/doc |
| 830 |
783 |
[ ] JUNK1/JUNK2: http://rg.embedromix.ro:8000/user/catab/rocketgit/commit/afd1df2..f919c9b |
[ ] JUNK1/JUNK2: http://rg.embedromix.ro:8000/user/catab/rocketgit/commit/afd1df2..f919c9b |
| 831 |
|
[ ] rg_log: why the fd is NULL?! |
|
| 832 |
|
[ ] We are escaping when we insert in database _and_ when we output on screen! |
|
| 833 |
|
What should we do? |
|
| 834 |
784 |
[ ] Add permission to add bug tracker to a project. |
[ ] Add permission to add bug tracker to a project. |
| 835 |
|
[ ] When repo is empty, we should not show the Log/Tree menu. |
|
| 836 |
785 |
[ ] @@branch@@ is not defined for merge requests. Should it? Probably yes, to filter them. |
[ ] @@branch@@ is not defined for merge requests. Should it? Probably yes, to filter them. |
| 837 |
|
[ ] Fix diff output. Cannot deal with renames/removes/etc. |
|
| 838 |
786 |
[ ] Check admin creating of an account. |
[ ] Check admin creating of an account. |
| 839 |
787 |
[ ] Add possibility to reject merge requests, to apply, to delete etc. |
[ ] Add possibility to reject merge requests, to apply, to delete etc. |
| 840 |
788 |
[ ] Do we need to escape some chars in console (ssh rocketgit@host repo X)? |
[ ] Do we need to escape some chars in console (ssh rocketgit@host repo X)? |
| |
| ... |
... |
them after processing is done. |
| 865 |
813 |
- First line should be <= 50 chars (short log); then an empty line |
- First line should be <= 50 chars (short log); then an empty line |
| 866 |
814 |
- Rest of commit message to be wrap at 72 chars. |
- Rest of commit message to be wrap at 72 chars. |
| 867 |
815 |
- Use git-request-pull for merge requests? |
- Use git-request-pull for merge requests? |
| 868 |
|
- Exemplu de pull rquest ok: https://groups.google.com/forum/#!topic/linux.kernel/w957vpu3PPU |
|
|
816 |
|
- Exemplu de pull request ok: https://groups.google.com/forum/#!topic/linux.kernel/w957vpu3PPU |
| 869 |
817 |
- |
- |
| 870 |
818 |
[ ] We need to have a link to current comment/etc. |
[ ] We need to have a link to current comment/etc. |
| 871 |
819 |
[ ] Warn if commit messages are too long (no wrap). |
[ ] Warn if commit messages are too long (no wrap). |
| |
| ... |
... |
them after processing is done. |
| 1045 |
993 |
== To recheck == |
== To recheck == |
| 1046 |
994 |
* http://techbase.kde.org/Projects/MovetoGit#Post_Update_hooks |
* http://techbase.kde.org/Projects/MovetoGit#Post_Update_hooks |
| 1047 |
995 |
* |
* |
| 1048 |
|
|
|
| 1049 |
|
|
|