xaizek / vifm (License: GPLv2+) (since 2018-12-07)
Vifm is a file manager with curses interface, which provides Vi[m]-like environment for managing objects within file systems, extended with some useful ideas from mutt.
Clone URLs: https://code.reversed.top/user/xaizek/vifm ssh://rocketgit@code.reversed.top/user/xaizek/vifm
v0.13 v0.13-beta v0.14 v0.14-beta master
Commit 9833c508ae276e3a37353931227c02817b72e39e

Fix a crash on drawing a tree-view
Happened when {ext} or {fileext} followed {name}, {iname}, {root} or
{fileroot}.

This was caused by commit 9b4e6721f3:

Apply file highlighting to "ext" and "fileext"

Those are view columns.

The reason is that column_line_print() assumed that all primary columns
can have a tree drawn on their left and the above commit made {ext} and
{fileext} count as such columns which combined with the fact that
*cdt->prefix_len was never reset caused this weird bug.

The bug however wasn't visible until commit
8e460ca64d75544b4bd880d7b75924fb886e53ce:

Make ui/column_view forget about ui/fileview.h

It's not supposed to know those details.

which added more fields to `struct format_info_t` which gets affected by
a buffer overrun by `strcpy(print_buf, buf);`.

Thanks to aw-cloud.

Fixes #1066 on GitHub.
Author: xaizek
Author date (UTC): 2025-03-24 17:08
Committer name: xaizek
Committer date (UTC): 2025-03-24 17:08
Parent(s): 6820a0e8ba52239c3b29f49e1c42df6eb824bab3
Signing key: 99DC5E4DB05F6BE2
Tree: f4a23010539107b4efb00c2af36866b1c2422e45
File Lines added Lines deleted
ChangeLog 3 0
THANKS 1 0
src/ui/fileview.c 3 0
tests/misc/ui.c 31 0
File ChangeLog changed (mode: 100644) (index ab7172f12..fee139e93)
14 14 instead of getmntent() API). The regression was apparently introduced in instead of getmntent() API). The regression was apparently introduced in
15 15 v0.9.1-beta. Thanks to sublimal. v0.9.1-beta. Thanks to sublimal.
16 16
17 Fixed a crash on drawing a tree-view when {ext} or {fileext} follows
18 {name}, {iname}, {root} or {fileroot}. Thanks to aw-cloud.
19
17 20 0.14-beta to 0.14 (2025-02-08) 0.14-beta to 0.14 (2025-02-08)
18 21
19 22 Improved documentation on zh/zl menu keys a bit. Improved documentation on zh/zl menu keys a bit.
File THANKS changed (mode: 100644) (index 651816784..5d7d72757)
... ... Artur Shaik (artur-shaik)
35 35 astrell astrell
36 36 AtomToast AtomToast
37 37 Aurelio Sanabria (Sufrostico) Aurelio Sanabria (Sufrostico)
38 aw-cloud
38 39 Azin Sharaf Azin Sharaf
39 40 b0x4it b0x4it
40 41 Badalisc Badalisc
File src/ui/fileview.c changed (mode: 100644) (index 536fe01d2..75ab2e78d)
... ... column_line_print(const char buf[], int offset, AlignType align,
1256 1256 wprinta(view->win, print_buf + match_from, &line_attrs, wprinta(view->win, print_buf + match_from, &line_attrs,
1257 1257 A_REVERSE | A_UNDERLINE); A_REVERSE | A_UNDERLINE);
1258 1258 } }
1259
1260 /* Use a given prefix value at most once. */
1261 *cdt->prefix_len = 0;
1259 1262 } }
1260 1263
1261 1264 /* Draws current line number at specified column. */ /* Draws current line number at specified column. */
File tests/misc/ui.c changed (mode: 100644) (index 5510c78d2..4a3084c71)
8 8 #include "../../src/cfg/config.h" #include "../../src/cfg/config.h"
9 9 #include "../../src/ui/color_scheme.h" #include "../../src/ui/color_scheme.h"
10 10 #include "../../src/ui/colored_line.h" #include "../../src/ui/colored_line.h"
11 #include "../../src/ui/column_view.h"
11 12 #include "../../src/ui/fileview.h" #include "../../src/ui/fileview.h"
12 13 #include "../../src/ui/tabs.h" #include "../../src/ui/tabs.h"
13 14 #include "../../src/ui/statusline.h" #include "../../src/ui/statusline.h"
14 15 #include "../../src/ui/ui.h" #include "../../src/ui/ui.h"
15 16 #include "../../src/utils/str.h" #include "../../src/utils/str.h"
17 #include "../../src/cmd_core.h"
16 18 #include "../../src/filelist.h" #include "../../src/filelist.h"
17 19
20 #include "utils.h"
21
18 22 static void check_tab_title(const tab_info_t *tab_info, const char text[]); static void check_tab_title(const tab_info_t *tab_info, const char text[]);
19 23 static char * identity(const char path[]); static char * identity(const char path[]);
20 24
 
... ... TEST(mouse_map_tlsview)
566 570 assert_int_equal(FVM_NONE, fview_map_coordinates(&lwin, 6, 5)); assert_int_equal(FVM_NONE, fview_map_coordinates(&lwin, 6, 5));
567 571 } }
568 572
573 TEST(prefix_len_is_reset_by_column_line_print)
574 {
575 curr_view = &lwin;
576 fview_setup();
577 cmds_init();
578 opt_handlers_setup();
579
580 assert_success(load_tree(&lwin, TEST_DATA_PATH "/tree", NULL));
581 assert_true(lwin.list_rows > 6);
582 lwin.list_pos = 6;
583 lwin.columns = columns_create();
584
585 assert_success(cmds_dispatch("set viewcolumns={name},{ext}", &lwin,
586 CIT_COMMAND));
587 curr_stats.load_stage = 2;
588 /* If this doesn't cause a crash or a memory issue, then there should be no
589 * bug related to tree prefix length computed for the {name} column being used
590 * for drawing {ext}. */
591 fview_cursor_redraw(&lwin);
592 curr_stats.load_stage = 0;
593
594 curr_view = NULL;
595 vle_cmds_reset();
596 opt_handlers_teardown();
597 columns_teardown();
598 }
599
569 600 static void static void
570 601 check_tab_title(const tab_info_t *tab_info, const char text[]) check_tab_title(const tab_info_t *tab_info, const char text[])
571 602 { {
Hints
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://code.reversed.top/user/xaizek/vifm

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@code.reversed.top/user/xaizek/vifm

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a pull request:
... clone the repository ...
... make some changes and some commits ...
git push origin master